[GitHub] [maven-resolver] cstamas commented on a diff in pull request #323: [MRESOLVER-393] Transport HTTP should retain last-modified

[via GitHub]

cstamas commented on code in PR #323:
URL: https://github.com/apache/maven-resolver/pull/323#discussion_r1279749516


##########
maven-resolver-transport-http/src/main/java/org/eclipse/aether/transport/http/HttpTransporter.java:
##########
@@ -641,6 +642,17 @@ public void handle(CloseableHttpResponse response) throws 
IOException, TransferC
                     task.setDataFile(dataFile);
                 }
             }
+            if (task.getDataFile() != null) {
+                Header lastModifiedHeader =
+                        response.getFirstHeader(HttpHeaders.LAST_MODIFIED); // 
note: Wagon also does first not last

Review Comment:
   ```suggestion
                           response.getFirstHeader(HttpHeaders.LAST_MODIFIED); 
// note: do same as Wagon
   ```



##########
maven-resolver-transport-http/src/main/java/org/eclipse/aether/transport/http/HttpTransporter.java:
##########
@@ -641,6 +642,17 @@ public void handle(CloseableHttpResponse response) throws 
IOException, TransferC
                     task.setDataFile(dataFile);
                 }
             }
+            if (task.getDataFile() != null) {
+                Header lastModifiedHeader =
+                        response.getFirstHeader(HttpHeaders.LAST_MODIFIED); // 
note: Wagon also does first not last

Review Comment:
   ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org