[
https://issues.apache.org/jira/browse/MSHARED-1297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17755297#comment-17755297
]
ASF GitHub Bot commented on MSHARED-1297:
-----------------------------------------
elharo commented on code in PR #42:
URL: https://github.com/apache/maven-archiver/pull/42#discussion_r1296514319
##########
src/main/java/org/apache/maven/archiver/MavenArchiver.java:
##########
@@ -800,6 +800,21 @@ public static Optional<Instant>
parseBuildOutputTimestamp(String outputTimestamp
}
}
+ private static boolean isNumeric(String str) {
+
+ if (str.isEmpty()) {
+ return false;
+ }
+
+ for (char c : str.toCharArray()) {
+ if (!Character.isDigit(c)) {
Review Comment:
This is likely not what you want. It includes lots of non-ASCII digits like
Devanagari digits. Long.parseLong won't work on these.
There might also be an issue with negative numbers.
> Prefer JDK features over plexus-utils, plexus-io
> ------------------------------------------------
>
> Key: MSHARED-1297
> URL: https://issues.apache.org/jira/browse/MSHARED-1297
> Project: Maven Shared Components
> Issue Type: Task
> Components: maven-archiver
> Reporter: Slawomir Jaranowski
> Assignee: Slawomir Jaranowski
> Priority: Major
> Fix For: maven-archiver-3.6.1
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
