elharo commented on code in PR #1208: URL: https://github.com/apache/maven/pull/1208#discussion_r1307372298
########## maven-compat/src/main/java/org/apache/maven/repository/legacy/DefaultWagonManager.java: ########## @@ -465,6 +469,28 @@ public void getRemoteFile( } } + private void copyFile(File source, File destination) throws IOException { + String message; + if (!source.exists()) { + message = "File " + source + " does not exist"; + throw new IOException(message); + } else if (!source.getCanonicalPath().equals(destination.getCanonicalPath())) { + File parentFile = destination.getParentFile(); + if (parentFile != null && !parentFile.exists()) { + parentFile.mkdirs(); Review Comment: The existing code is buggy and can fail. There is no guarantee mkdirs succeeds here. ########## maven-compat/src/main/java/org/apache/maven/repository/legacy/DefaultWagonManager.java: ########## @@ -465,6 +469,28 @@ public void getRemoteFile( } } + private void copyFile(File source, File destination) throws IOException { + String message; + if (!source.exists()) { + message = "File " + source + " does not exist"; + throw new IOException(message); + } else if (!source.getCanonicalPath().equals(destination.getCanonicalPath())) { + File parentFile = destination.getParentFile(); + if (parentFile != null && !parentFile.exists()) { + parentFile.mkdirs(); + } + Files.copy( + source.toPath(), + destination.toPath(), + StandardCopyOption.REPLACE_EXISTING, + StandardCopyOption.COPY_ATTRIBUTES); + if (source.length() != destination.length()) { Review Comment: There's some shared history between all of these, and they have the same failure modes and issues. That's why we need to move away from all of them and use the JDK methods that are available in Java 7+ that did not exist 20 years ago when this buggy code was first written. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org