[
https://issues.apache.org/jira/browse/MDEPLOY-312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774973#comment-17774973
]
Tamas Cservenak edited comment on MDEPLOY-312 at 10/13/23 4:05 PM:
-------------------------------------------------------------------
Those are not "resolved" but "transformed" (and by deploy, on purpose). Also,
those (deployed, remote) files has nothing to do with Project ongoing.
Moreover, in Maven4 within deployer is where consumer POM transformation
happens, and deploy is _on purpose_ encapsulated and "hidden" from everything
else, unlike in old Maven2.
To me it looks like your "custom resolver" should rely on remote repository
metadata, to _properly resolve_ the freshly deployed artifacts? As to me it
seems that currently it does not. Your logic relied on Maven2 behaviour (hence
is/was in maven-compat), where this is not the case since Maven3 and
introduction of Resolver...
Given this is totally orthogonal (at least to Maven core) and core decidedly
has nothing to do with this, I'd rather recommend to listen for
org.eclipse.aether.RepositoryEvent.EventType#ARTIFACT_DEPLOYED events, as those
will carry the "transformed" (timestamped) version of artifact. Would that work
for you?
was (Author: cstamas):
Those are not "resolved" but "transformed" (and by deploy, on purpose). Also,
those (deployed, remote) files has nothing to do with Project ongoing.
Moreover, in Maven4 within deployer is where transformation happens, and deploy
is _on purpose_ encapsulated and "hidden" from everything else, unlike in old
Maven2.
To me it looks like your "custom resolver" should rely on remote repository
metadata, to _properly resolve_ the freshly deployed artifacts? As to me it
seems that currently it does not. Your logic relied on Maven2 behaviour (hence
is/was in maven-compat), where this is not the case since Maven3 and
introduction of Resolver...
Given this is totally orthogonal (at least to Maven core) and core decidedly
has nothing to do with this, I'd rather recommend to listen for
org.eclipse.aether.RepositoryEvent.EventType#ARTIFACT_DEPLOYED events, as those
will carry the "transformed" (timestamped) version of artifact. Would that work
for you?
> [REGRESSION] deploy no longer updates project model
> ---------------------------------------------------
>
> Key: MDEPLOY-312
> URL: https://issues.apache.org/jira/browse/MDEPLOY-312
> Project: Maven Deploy Plugin
> Issue Type: Bug
> Components: deploy:deploy, deploy:deploy-file
> Affects Versions: 3.0.0
> Reporter: Jared Stehler
> Priority: Major
>
> Prior to 3.0.0, the maven-deploy-plugin would update artifacts on the Project
> model:
> *
> [https://github.com/apache/maven/blob/master/maven-compat/src/main/java/org/apache/maven/artifact/deployer/DefaultArtifactDeployer.java#L147]
> *
> [https://github.com/apache/maven-deploy-plugin/blob/maven-deploy-plugin-2.8.2/src/main/java/org/apache/maven/plugin/deploy/DeployFileMojo.java#L276]
> This is no longer occurring with the migration to maven-resolver, which is
> breaking our downstream plugins relying on the resolved SNAPSHOT version.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
