[ https://issues.apache.org/jira/browse/MCLEAN-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17776631#comment-17776631 ]
ASF GitHub Bot commented on MCLEAN-102: --------------------------------------- wilx opened a new pull request, #32: URL: https://github.com/apache/maven-clean-plugin/pull/32 Pass `GlobSelector` instance into `cleaner.delete()` only if it matters. Passing `GlobSelector` always breaks the fast delete feature. Following this checklist to help us incorporate your contribution quickly and easily: - [X] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MCLEAN) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [X] Each commit in the pull request should have a meaningful subject line and body. - [X] Format the pull request title like `[MCLEAN-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MCLEAN-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [X] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [X] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [X] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). > Fast is slower on windows with many cores > ----------------------------------------- > > Key: MCLEAN-102 > URL: https://issues.apache.org/jira/browse/MCLEAN-102 > Project: Maven Clean Plugin > Issue Type: Bug > Affects Versions: 3.2.0 > Environment: Windows 10 > Reporter: Delany > Priority: Major > > I run a 500+ module project with 4 core Linux and experience a 20sec > improvement in reactor build time when enabling the fast. > My one colleagues runs the same build with 4 cores on Windows and also sees > an improvement. > But two other colleagues run the same build with 12 cores on Windows (one > uses cygwin, the other powershell) and they consistently see a slowdown from > 2:14 to 3:23, for example. -- This message was sent by Atlassian Jira (v8.20.10#820010)