gnodet commented on code in PR #1269: URL: https://github.com/apache/maven/pull/1269#discussion_r1365000724
########## maven-embedder/src/main/java/org/apache/maven/cli/transfer/ConsoleMavenTransferListener.java: ########## @@ -135,7 +136,7 @@ public synchronized void transferFailed(TransferEvent event) { private void overridePreviousTransfer(TransferEvent event) { if (lastLength > 0) { - StringBuilder buffer = new StringBuilder(128); + StringBuilder buffer = new StringBuilder(lastLength + 1); Review Comment: This class is completely (and overly btw) synchronised, so why not using a single `StringBuilder buffer` field and use `setLength(0)` when needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org