sebastien-doyon commented on PR #1269: URL: https://github.com/apache/maven/pull/1269#issuecomment-1772754240
@gnodet > There are still a couple of things to clean in this package.... > `FileSizeFormat` should be moved to top level Done in the last commit > it should be refactored to accept an `Appender` as argument Done in the last commit, the `FileSizeFormat.formatProcess()` was refactored to accept an `StringBuilder` as argument > `BatchModeMavenTransferListener` should be removed Done in the last commit > `Slf4jMavenTransferListener` should inherit `AbstractMavenTransferListener` I leave this one for another PR, I suggest transform the `AbstractMavenTransferListener` to a message formatter class that would contain the common code building the text, and move to `PrintStream` code to the `ConsoleMavenTransferListener`. Maybe in the 1279 PR or a subsequent one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
