michael-o commented on PR #26: URL: https://github.com/apache/maven-reporting-impl/pull/26#issuecomment-1798296831
> > would you keep it in the build output dir directory? What is your opinion on the clutter? > > Good catch! My use case with AspectJ reporting is a multi-page report, for which always a subdirectory is created anyway. > > Honestly, when fixing the ITs here, I did not check whether there was additional clutter written into the build directory, because I think that each mojo writing more than a single file - say PDF, HTML or whatever - ought to take care of creating a subdir for itself anyway, because **the same clutter would also end up in the reporting directory with the old default,** dangerously mixing with the output of other plugins. So arguably, the demo plugin in the IT does not behave well. > > If the equation `single report file != single file written` is true for a single-page report, it ought to create a subdirectory. Then, the problem would be solved, no matter which base directory (sorry for the term "base" again) the report gets written to. It is not that easy. Even if a plugin uses a subdir in the shared one, there are still assets from the skin which need to be present to properly render the report in the browser. They are irrelevant for an external one, but everything else it is not. Overriding the assets isn't a problem because they all use the same skin. This is harmless. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
