laeubi commented on PR #364:
URL: https://github.com/apache/maven-resolver/pull/364#issuecomment-1814261616

   > I really hope "atomic on windows" will NOT replace the file and then throw 
😄 otherwise, am really unsure what that OS is able to guarantee for at all.
   
   You can just look into the Widnows File system implementation of the JDK to 
see whats going on.
   
   > If you check older resolvers (and let's assume "they worked"), they used 
pre-nio2 copy+delete
   
   "Old" code simply ignored when replace goes wrong, so you have the problem 
that afterwards you maybe use the old file. I don't say that new way is "wrong" 
just that not using atomic move does not solve the problem reported in the 
issue that is some other process (or the current) is currently opend that file 
and in such case you cam't overwrite/delete/replace/move ... to that file under 
windows.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to