[
https://issues.apache.org/jira/browse/MCOMPILER-542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17789225#comment-17789225
]
Herve Boutemy edited comment on MCOMPILER-542 at 11/23/23 5:44 PM:
-------------------------------------------------------------------
it's part of the review and improvement I want to make if possible: activate
the rewrite when necessary, given JDK release and release configuration, to not
activate it when > 21 (if the fix ships in 21)
and also display an info message with a count of fixes done, just to avoid
having a silent (hack) feature
was (Author: hboutemy):
it's part of the review and improvement I want to make if possible: activate
the rewrite when necessary, given JDK release and release configuration, to not
activate it when > 21 (if the fix ships in 21)
and also display an info message with a count of fixes done, just not avoid
having a silent (hack) feature
> clean JDK patch version in module-info.class
> --------------------------------------------
>
> Key: MCOMPILER-542
> URL: https://issues.apache.org/jira/browse/MCOMPILER-542
> Project: Maven Compiler Plugin
> Issue Type: Improvement
> Affects Versions: 3.11.0
> Reporter: Herve Boutemy
> Assignee: Herve Boutemy
> Priority: Major
> Fix For: 3.12.0
>
>
> as seen in MJAR-275, JDK patch version in module-info.class is NOT included
> only when building with a newer JDK release using "--release" flag, see
> [https://github.com/jvm-repo-rebuild/module-info]
> issue [https://bugs.openjdk.org/browse/JDK-8318913] created in JDK to get a
> proper fix at javac level (probably for Java 22)
> and waiting for that, we need a workaround to drop the JDK patch version in
> other cases: we'll need to define where is the best place –
> m-jar-p?m-compiler-p? other?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
