[ https://issues.apache.org/jira/browse/MSHARED-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17792317#comment-17792317 ]
ASF GitHub Bot commented on MSHARED-1285: ----------------------------------------- laeubi commented on PR #77: URL: https://github.com/apache/maven-filtering/pull/77#issuecomment-1837037738 @lalmeras great to see you make progress on this :+1: For the second case assume the following: 1. A resource (e.g. `source.txt`) was recently copied to the output folder `output` 2. There is another resource (e.g. `source2.txt`) also copied to the output folder `output` 3. Now it happens that `output/source.txt` is modified e.g. by the user outside the scope of changes 4. Now `source2.txt` is modified and only this edit is part of the change scope What happens now is that `source2.txt` is copied correctly to folder `output` as it is part of the changed files, but `source.txt` is not copied even though it is out-of-date with `output/source.txt`. > DefaultMavenResourcesFiltering uses BuildContext in a way that fails sometimes > ------------------------------------------------------------------------------ > > Key: MSHARED-1285 > URL: https://issues.apache.org/jira/browse/MSHARED-1285 > Project: Maven Shared Components > Issue Type: Bug > Reporter: Christoph Läubrich > Priority: Major > > The maven resources plugin uses > [https://github.com/apache/maven-filtering/blob/master/src/main/java/org/apache/maven/shared/filtering/DefaultMavenResourcesFiltering.java] > to copy resources, but that component has some subtile flaws reported here: > [https://github.com/eclipse-m2e/m2e-core/discussions/1468] > The problematic part is the usage of BuildContext#newScanner that already > mentions in the javadoc that passing ignoreDelta to neScanner might not > reveal all required items +*for copy-resources*+ form A -> B and instead > BuildContext#isUpTodate should be used. > Just from a quick look I assume that part of code actually wants to use > something like this: > {code:java} > DirectoryScanner ds = new DirectoryScanner() { > @Override > protected boolean isSelected(String name, File file) { > if (file.isFile() && buildContext.isUptodate(getTargetFile(file), file)) > { > return false; > } > return true; > } > }; > ds.setBasedir(basedir); {code} > That way all the code that currently checks for if output directory existed > before can also be removed what is another issue because it leads to a full > resources copy even if source+target are already even if a single class file > is changed while the idea seems more that if the output was not there it > should not try to be incremental! -- This message was sent by Atlassian Jira (v8.20.10#820010)