michael-o commented on code in PR #202:
URL: https://github.com/apache/maven-release/pull/202#discussion_r1421564124
##########
maven-release-manager/src/main/java/org/apache/maven/shared/release/transform/jdom2/JDomModel.java:
##########
@@ -198,7 +199,17 @@ public void setVersion(String version) {
AbstractRewritePomsPhase.extractPropertyFromExpression(versionElement.getTextNormalize());
Properties properties = getProperties();
if (properties != null) {
- properties.computeIfPresent(ciFriendlyPropertyName, (k, v)
-> version);
+ String sha1 = properties.getProperty("sha1", "");
+ String changelist = properties.getProperty("changelist",
"");
+ properties.setProperty(
+ ciFriendlyPropertyName,
+ // assume that everybody follows the example and
properties are simply chained
+ version.replaceAll(sha1,
"").replaceAll(changelist, ""));
Review Comment:
I still consider using a regex method wrong here...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
