[
https://issues.apache.org/jira/browse/MARCHETYPES-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17799738#comment-17799738
]
ASF GitHub Bot commented on MARCHETYPES-78:
-------------------------------------------
judovana opened a new pull request, #20:
URL: https://github.com/apache/maven-archetypes/pull/20
hi!
Similarly as in https://github.com/apache/maven-archetypes/pull/18 the jdk7
bytecode is no longr viable in jdk21 world, and no one should be using jdk7.
Thus - much more simple then
https://github.com/apache/maven-archetypes/pull/18 - bulk bump of 1.7 maven
compiler settings to 1.8
I can not swear that I had not missed any, but I did my best to not miss any.
- [x] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/projects/MARCHETYPES/issues/MARCHETYPES-78)
filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line
and body.
- [x] Format the pull request title like `[MARCHETYPES-XXX] SUMMARY`, where
you replace `MARCHETYPES-XXX`
and `SUMMARY` with the appropriate JIRA issue. Best practice is to
use the JIRA issue
title in the pull request title and in the first line of the commit
message.
- [x] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
> archetypes generates EOLed maven.compiler versions
> --------------------------------------------------
>
> Key: MARCHETYPES-78
> URL: https://issues.apache.org/jira/browse/MARCHETYPES-78
> Project: Maven Archetype Bundles
> Issue Type: Bug
> Reporter: jiri vanek
> Priority: Major
>
> namely at least
> maven-archetype-plugin/src/main/resources-filtered/archetype-resources/pom.xml
> maven-archetype-archetype/src/main/resources-filtered/archetype-resources/src/main/resources/archetype-resources/pom.xml
> maven-archetype-archetype/src/main/resources-filtered/archetype-resources/pom.xml
> maven-archetype-profiles/src/main/resources-filtered/archetype-resources/pom.xml
> maven-archetype-simple/src/main/resources-filtered/archetype-resources/pom.xml
> maven-archetype-portlet/src/main/resources-filtered/archetype-resources/pom.xml
> maven-archetype-quickstart/src/main/resources-filtered/archetype-resources/pom.xml
> still uses 1.7 as default version.
> I'm happy to fix them all (see
> https://github.com/apache/maven-archetypes/pull/18 and
> https://issues.apache.org/jira/projects/MARCHETYPES/issues/MARCHETYPES-76),
> but first I need some ack from somebody with commit permissions to
> MARCHETYPES/https://github.com/apache/maven-archetypes
> {code:java}
> grep -ir -e maven.compiler.source -e maven.compiler.target| grep -v test
> maven-archetype-plugin/src/main/resources-filtered/archetype-resources/pom.xml:
> <maven.compiler.source>1.7</maven.compiler.source>
> maven-archetype-plugin/src/main/resources-filtered/archetype-resources/pom.xml:
> <maven.compiler.target>1.7</maven.compiler.target>
> maven-archetype-archetype/src/main/resources-filtered/archetype-resources/src/main/resources/archetype-resources/pom.xml:
> <maven.compiler.source>1.7</maven.compiler.source>
> maven-archetype-archetype/src/main/resources-filtered/archetype-resources/src/main/resources/archetype-resources/pom.xml:
> <maven.compiler.target>1.7</maven.compiler.target>
> maven-archetype-archetype/src/main/resources-filtered/archetype-resources/pom.xml:
> <maven.compiler.source>1.7</maven.compiler.source>
> maven-archetype-archetype/src/main/resources-filtered/archetype-resources/pom.xml:
> <maven.compiler.target>1.7</maven.compiler.target>
> maven-archetype-profiles/src/main/resources-filtered/archetype-resources/pom.xml:
> <maven.compiler.source>1.7</maven.compiler.source>
> maven-archetype-profiles/src/main/resources-filtered/archetype-resources/pom.xml:
> <maven.compiler.target>1.7</maven.compiler.target>
> maven-archetype-webapp/src/main/resources-filtered/archetype-resources/pom.xml:
> <maven.compiler.source>1.8</maven.compiler.source>
> maven-archetype-webapp/src/main/resources-filtered/archetype-resources/pom.xml:
> <maven.compiler.target>1.8</maven.compiler.target>
> maven-archetype-simple/src/main/resources-filtered/archetype-resources/pom.xml:
> <maven.compiler.source>1.7</maven.compiler.source>
> maven-archetype-simple/src/main/resources-filtered/archetype-resources/pom.xml:
> <maven.compiler.target>1.7</maven.compiler.target>
> maven-archetype-portlet/src/main/resources-filtered/archetype-resources/pom.xml:
> <maven.compiler.source>1.7</maven.compiler.source>
> maven-archetype-portlet/src/main/resources-filtered/archetype-resources/pom.xml:
> <maven.compiler.target>1.7</maven.compiler.target>
> maven-archetype-quickstart/src/main/resources-filtered/archetype-resources/pom.xml:
> <maven.compiler.source>${jcv}</maven.compiler.source>
> maven-archetype-quickstart/src/main/resources-filtered/archetype-resources/pom.xml:
> <maven.compiler.target>${jcv}</maven.compiler.target>
> {code}
> with tests:
> {code:java}
> grep -ir -e maven.compiler.source -e maven.compiler.target
> maven-archetype-plugin/src/main/resources-filtered/archetype-resources/pom.xml:
> <maven.compiler.source>1.7</maven.compiler.source>
> maven-archetype-plugin/src/main/resources-filtered/archetype-resources/pom.xml:
> <maven.compiler.target>1.7</maven.compiler.target>
> maven-archetype-archetype/src/main/resources-filtered/archetype-resources/src/main/resources/archetype-resources/pom.xml:
> <maven.compiler.source>1.7</maven.compiler.source>
> maven-archetype-archetype/src/main/resources-filtered/archetype-resources/src/main/resources/archetype-resources/pom.xml:
> <maven.compiler.target>1.7</maven.compiler.target>
> maven-archetype-archetype/src/main/resources-filtered/archetype-resources/pom.xml:
> <maven.compiler.source>1.7</maven.compiler.source>
> maven-archetype-archetype/src/main/resources-filtered/archetype-resources/pom.xml:
> <maven.compiler.target>1.7</maven.compiler.target>
> maven-archetype-profiles/src/main/resources-filtered/archetype-resources/pom.xml:
> <maven.compiler.source>1.7</maven.compiler.source>
> maven-archetype-profiles/src/main/resources-filtered/archetype-resources/pom.xml:
> <maven.compiler.target>1.7</maven.compiler.target>
> maven-archetype-webapp/src/main/resources-filtered/archetype-resources/pom.xml:
> <maven.compiler.source>1.8</maven.compiler.source>
> maven-archetype-webapp/src/main/resources-filtered/archetype-resources/pom.xml:
> <maven.compiler.target>1.8</maven.compiler.target>
> maven-archetype-simple/src/main/resources-filtered/archetype-resources/pom.xml:
> <maven.compiler.source>1.7</maven.compiler.source>
> maven-archetype-simple/src/main/resources-filtered/archetype-resources/pom.xml:
> <maven.compiler.target>1.7</maven.compiler.target>
> maven-archetype-portlet/src/main/resources-filtered/archetype-resources/pom.xml:
> <maven.compiler.source>1.7</maven.compiler.source>
> maven-archetype-portlet/src/main/resources-filtered/archetype-resources/pom.xml:
> <maven.compiler.target>1.7</maven.compiler.target>
> maven-archetype-quickstart/src/main/resources-filtered/archetype-resources/pom.xml:
> <maven.compiler.source>${jcv}</maven.compiler.source>
> maven-archetype-quickstart/src/main/resources-filtered/archetype-resources/pom.xml:
> <maven.compiler.target>${jcv}</maven.compiler.target>
> maven-archetype-quickstart/src/test/resources/projects/it-java-7/reference/pom.xml:
> <maven.compiler.source>1.7</maven.compiler.source>
> maven-archetype-quickstart/src/test/resources/projects/it-java-7/reference/pom.xml:
> <maven.compiler.target>1.7</maven.compiler.target>
> maven-archetype-quickstart/src/test/resources/projects/it-java-7-junit-4.12/reference/pom.xml:
> <maven.compiler.source>1.7</maven.compiler.source>
> maven-archetype-quickstart/src/test/resources/projects/it-java-7-junit-4.12/reference/pom.xml:
> <maven.compiler.target>1.7</maven.compiler.target>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
