[
https://issues.apache.org/jira/browse/DOXIA-711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17800089#comment-17800089
]
ASF GitHub Bot commented on DOXIA-711:
--------------------------------------
kwin commented on code in PR #184:
URL: https://github.com/apache/maven-doxia/pull/184#discussion_r1435679435
##########
doxia-core/src/main/java/org/apache/maven/doxia/parser/SinkWrapper.java:
##########
Review Comment:
Should we move this to another package? Maybe `o.a.m.doxia.sink.impl` is
better, but this is clearly no impl details but rather class to be reused among
doxia modules and potentially other consumers. Usually `impl` packages are used
for packages which should not be reused outside the current JAR. So maybe
`o.a.m.doxia.sink` is better, OTOH all other classes in `o.a.m.doxia.sink.impl`
are probably not belonging to an impl package either, as all of them are
reused. WDYT @michael-o
> Introduce SinkWrapper with factory
> ----------------------------------
>
> Key: DOXIA-711
> URL: https://issues.apache.org/jira/browse/DOXIA-711
> Project: Maven Doxia
> Issue Type: Improvement
> Components: Core
> Reporter: Konrad Windszus
> Assignee: Konrad Windszus
> Priority: Major
> Fix For: 2.0.0-M9
>
>
> Similar to HttpServletRequestWrapper in Servlet API one should have a
> SinkWrapper helper for Doxia. That allows to easily implement some
> post/preprocessing and even modifying or skipping the underlying sink. All
> Sink wrappers and the original sink should form a pipeline.
> Registering a SinkWrapper should optionally be done automatically (via JSR330
> annotations) or manually.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
