[ 
https://issues.apache.org/jira/browse/MARCHETYPES-76?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17800293#comment-17800293
 ] 

ASF GitHub Bot commented on MARCHETYPES-76:
-------------------------------------------

judovana opened a new pull request, #25:
URL: https://github.com/apache/maven-archetypes/pull/25

   if the https://github.com/apache/maven-archetypes/pull/24 will be merged, 
the [MARCHETYPES-76] will be fixed too, however the 
   1.8 bump  test for maven-archetype-quickstart  will lost sesne/
   
   The test should be changed from bump 1.7 -> 1.8  to downgrade 1.8 to 1.7, so 
 the action is of "change the jdk" will persist. and - as bumps to modular jdks 
are there,  change to non-=modular jdk should remain here,  as ther eis "if" in 
moacros to modular/non modular jdk, so even once defualt jdk will be modular, 
the downgrade to non modular jdk should remia here
   
    - [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/MARCHETYPES) filed
          for the change (usually before you start working on it).  Trivial 
changes like typos do not
          require a JIRA issue. Your pull request should address just this 
issue, without
          pulling in other changes.
    - [ ] Each commit in the pull request should have a meaningful subject line 
and body.
    - [ ] Format the pull request title like `[MARCHETYPES-XXX] SUMMARY`, where 
you replace `MARCHETYPES-XXX`
          and `SUMMARY` with the appropriate JIRA issue. Best practice is to 
use the JIRA issue
          title in the pull request title and in the first line of the commit 
message.
    - [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
    - [ ] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will
          be performed on your pull request automatically.
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
    - [ ] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
    - [ ] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   




> maven-archetype-quickstart generates EOLed  maven.compiler setup
> ----------------------------------------------------------------
>
>                 Key: MARCHETYPES-76
>                 URL: https://issues.apache.org/jira/browse/MARCHETYPES-76
>             Project: Maven Archetype Bundles
>          Issue Type: Bug
>          Components: Maven Quickstart Archetype
>            Reporter: jiri vanek
>            Priority: Major
>
> The default imput to #compilerProperties is 1.7, which is making any 
> generated project to be not buildable with fresh jdk21. The default should 
> be1.8. Where jdk8 is still live and jdk21 is still comaptible with it.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to