[
https://issues.apache.org/jira/browse/MARCHETYPES-76?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17799779#comment-17799779
]
ASF GitHub Bot commented on MARCHETYPES-76:
-------------------------------------------
judovana commented on code in PR #22:
URL: https://github.com/apache/maven-archetypes/pull/22#discussion_r1434949427
##########
.github/workflows/maven-verify.yml:
##########
@@ -25,3 +25,5 @@ jobs:
build:
name: Verify
uses: apache/maven-gh-actions-shared/.github/workflows/maven-verify.yml@v3
+ with:
+ jdk-matrix: '[ "8", "11", "17", "21" ]'
Review Comment:
Sure it is. And I agree wiht it. But not in the way you did it.
You had mixed three parts in one PR I do not understand why. This should be
separate PR, whcihshoudl go in before
https://github.com/apache/maven-archetypes/pull/20
Aslo you are reverting the change which was agreed during review of #18
> maven-archetype-quickstart generates EOLed maven.compiler setup
> ----------------------------------------------------------------
>
> Key: MARCHETYPES-76
> URL: https://issues.apache.org/jira/browse/MARCHETYPES-76
> Project: Maven Archetype Bundles
> Issue Type: Bug
> Components: Maven Quickstart Archetype
> Reporter: jiri vanek
> Priority: Major
> Fix For: 1.5
>
>
> The default imput to #compilerProperties is 1.7, which is making any
> generated project to be not buildable with fresh jdk21. The default should
> be1.8. Where jdk8 is still live and jdk21 is still comaptible with it.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
