michael-o commented on code in PR #702:
URL: https://github.com/apache/maven-surefire/pull/702#discussion_r1440247439
##########
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/StatelessXmlReporter.java:
##########
@@ -456,21 +456,13 @@ private static void getTestProblems(
}
}
- boolean hasNestedElements = createOutErrElementsInside & stackTrace !=
null;
-
- if (stackTrace != null) {
- if (hasNestedElements) {
- ppw.startElement("stackTrace");
+ if (enableNestedOutErrElements) {
+ ppw.startElement("stackTrace");
+ if (stackTrace != null) {
+ extraEscapeElementValue(stackTrace, outputStreamWriter, ppw,
fw);
}
+ ppw.endElement();
- extraEscapeElementValue(stackTrace, outputStreamWriter, ppw, fw);
Review Comment:
Thanks for the confirmation. I will cancel the vote today, create an
improvement request to change the schema in the next major to a complex element
with `stackTrace` to align with the rest and another one to fix this
regression. I will ping you as soon as I have something to test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
