[
https://issues.apache.org/jira/browse/SUREFIRE-2224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17802226#comment-17802226
]
ASF GitHub Bot commented on SUREFIRE-2224:
------------------------------------------
michael-o commented on code in PR #702:
URL: https://github.com/apache/maven-surefire/pull/702#discussion_r1440602428
##########
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/StatelessXmlReporter.java:
##########
@@ -456,21 +456,13 @@ private static void getTestProblems(
}
}
- boolean hasNestedElements = createOutErrElementsInside & stackTrace !=
null;
-
- if (stackTrace != null) {
- if (hasNestedElements) {
- ppw.startElement("stackTrace");
+ if (enableNestedOutErrElements) {
+ ppw.startElement("stackTrace");
+ if (stackTrace != null) {
+ extraEscapeElementValue(stackTrace, outputStreamWriter, ppw,
fw);
}
+ ppw.endElement();
- extraEscapeElementValue(stackTrace, outputStreamWriter, ppw, fw);
Review Comment:
Fix: https://github.com/apache/maven-surefire/pull/709
> StatelessXmlReporter#getTestProblems() does not properly reflect report
> schema structure
> ----------------------------------------------------------------------------------------
>
> Key: SUREFIRE-2224
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2224
> Project: Maven Surefire
> Issue Type: Bug
> Components: xml generation
> Affects Versions: 3.2.3
> Reporter: Michael Osipov
> Assignee: Michael Osipov
> Priority: Major
> Fix For: 3.2.4, 3.2.5
>
>
> According to
> https://maven.apache.org/surefire/maven-surefire-plugin/xsd/surefire-test-report.xsd
> and
> https://maven.apache.org/surefire/maven-failsafe-plugin/xsd/failsafe-test-report.xsd
> not all nested elements contain {{stackTrace}}, {{system-out}} and
> {{system-err}} elements, but the code makes it conditional whether there is a
> stack trace or not. This does not comply with the schema definition. Either
> the nested element is simple content or complex. In the latter {{stackTrace}}
> is mandatory, even if there is no strack trace according to the schema. The
> system streams are optional.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
