michael-o commented on code in PR #125: URL: https://github.com/apache/maven-doxia-sitetools/pull/125#discussion_r1440867789
########## doxia-integration-tools/pom.xml: ########## @@ -86,9 +86,15 @@ <scope>provided</scope> </dependency> <dependency> - <groupId>org.apache.maven</groupId> - <artifactId>maven-plugin-api</artifactId> - <version>${mavenVersion}</version> + <groupId>org.eclipse.aether</groupId> + <artifactId>aether-api</artifactId> + <version>${aetherVersion}</version> + <scope>provided</scope> + </dependency> + <dependency> + <groupId>org.eclipse.aether</groupId> + <artifactId>aether-impl</artifactId> Review Comment: I see this and `maven-core` is in `provided` scope, why should we exclude all deps? Moreover, we don't exclude in other components. I don't fully understand the reasoning. Tree: ``` [INFO] +- org.apache.maven:maven-core:jar:3.2.5:provided [INFO] | +- org.apache.maven:maven-settings:jar:3.2.5:provided [INFO] | +- org.apache.maven:maven-settings-builder:jar:3.2.5:provided [INFO] | +- org.apache.maven:maven-repository-metadata:jar:3.2.5:provided [INFO] | +- org.apache.maven:maven-plugin-api:jar:3.2.5:provided [INFO] | +- org.apache.maven:maven-model-builder:jar:3.2.5:provided [INFO] | +- org.eclipse.aether:aether-util:jar:1.0.0.v20140518:provided [INFO] | +- org.sonatype.sisu:sisu-guice:jar:no_aop:3.2.3:provided [INFO] | +- org.codehaus.plexus:plexus-classworlds:jar:2.5.2:compile [INFO] | +- org.codehaus.plexus:plexus-component-annotations:jar:1.5.5:compile [INFO] | \- org.sonatype.plexus:plexus-sec-dispatcher:jar:1.3:provided [INFO] | \- org.sonatype.plexus:plexus-cipher:jar:1.4:provided ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org