[
https://issues.apache.org/jira/browse/SUREFIRE-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803369#comment-17803369
]
ASF GitHub Bot commented on SUREFIRE-2231:
------------------------------------------
slachiewicz commented on PR #710:
URL: https://github.com/apache/maven-surefire/pull/710#issuecomment-1877964618
Nice spot
> JaCoCo 0.8.11 fails with old TestNG releases on Java 17+
> --------------------------------------------------------
>
> Key: SUREFIRE-2231
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2231
> Project: Maven Surefire
> Issue Type: Bug
> Affects Versions: 3.2.3
> Reporter: Michael Osipov
> Priority: Major
>
> Upgrade JaCoCo to 0.8.11 and watch many TestNGs ITs fail. A lot still use
> TestNG 5.7 which seems to be broken with Java 17+. We either need to remove
> them or upgrade the entire test setup to 6+ which should work on Java 17+ as
> well:
> {noformat}
> $ grep -r '"testNgVersion"' surefire-its/src/test/ --color
> surefire-its/src/test/java/org/apache/maven/surefire/its/CheckTestNgBeforeMethodFailureIT.java:
> .sysProp("testNgVersion", "5.7")
> surefire-its/src/test/java/org/apache/maven/surefire/its/CheckTestNgBeforeMethodIT.java:
> .sysProp("testNgVersion", "5.7")
> surefire-its/src/test/java/org/apache/maven/surefire/its/CheckTestNgExecuteErrorIT.java:
> .sysProp("testNgVersion", "5.7")
> surefire-its/src/test/java/org/apache/maven/surefire/its/CheckTestNgGroupThreadParallelIT.java:
> .sysProp("testNgVersion", "5.7")
> surefire-its/src/test/java/org/apache/maven/surefire/its/CheckTestNgListenerReporterIT.java:
> unpack("testng-listener-reporter", "_" +
> version).sysProp("testNgVersion", version);
> surefire-its/src/test/java/org/apache/maven/surefire/its/CheckTestNgPathWithSpacesIT.java:
> .sysProp("testNgVersion", "5.7")
> surefire-its/src/test/java/org/apache/maven/surefire/its/CheckTestNgReportTestIT.java:
> .sysProp("testNgVersion", "5.7")
> surefire-its/src/test/java/org/apache/maven/surefire/its/CheckTestNgReportTestIT.java:
> .sysProp("testNgVersion", "5.10")
> surefire-its/src/test/java/org/apache/maven/surefire/its/CheckTestNgReportTestIT.java:
> .sysProp("testNgVersion", "5.10")
> surefire-its/src/test/java/org/apache/maven/surefire/its/CheckTestNgSuiteXmlIT.java:
> return unpack("testng-suite-xml").sysProp("testNgVersion",
> "5.7").sysProp("testNgClassifier", "jdk15");
> surefire-its/src/test/java/org/apache/maven/surefire/its/CheckTestNgSuiteXmlSingleIT.java:
> .sysProp("testNgVersion", "5.7")
> surefire-its/src/test/java/org/apache/maven/surefire/its/CheckTestNgVersionsIT.java:
> final SurefireLauncher launcher =
> unpack("testng-simple").sysProp("testNgVersion", version);
> surefire-its/src/test/java/org/apache/maven/surefire/its/TestMethodPatternIT.java:
> props.put("testNgVersion", "5.7");
> surefire-its/src/test/java/org/apache/maven/surefire/its/TestMethodPatternIT.java:
> props.put("testNgVersion", "5.7");
> surefire-its/src/test/java/org/apache/maven/surefire/its/TestMethodPatternIT.java:
> .sysProp("testNgVersion", "5.7")
> surefire-its/src/test/java/org/apache/maven/surefire/its/TestNgSuccessPercentageIT.java:
> .sysProp("testNgVersion", "5.7")
> surefire-its/src/test/java/org/apache/maven/surefire/its/TestSingleMethodIT.java:
> props.put("testNgVersion", "5.7");
> surefire-its/src/test/java/org/apache/maven/surefire/its/TestSingleMethodIT.java:
> props.put("testNgVersion", "5.7");
> surefire-its/src/test/java/org/apache/maven/surefire/its/TwoTestCasesIT.java:
> .sysProp("testNgVersion", "5.7")
> surefire-its/src/test/java/org/apache/maven/surefire/its/TwoTestCasesIT.java:
> .sysProp("testNgVersion", "5.7")
> surefire-its/src/test/java/org/apache/maven/surefire/its/TwoTestCasesIT.java:
> .sysProp("testNgVersion", "5.7")
> surefire-its/src/test/java/org/apache/maven/surefire/its/TwoTestCasesIT.java:
> .sysProp("testNgVersion", "5.7")
> surefire-its/src/test/java/org/apache/maven/surefire/its/jiras/Surefire1135ImproveIgnoreMessageForTestNGIT.java:
> SurefireLauncher launcher = unpack(resource).sysProp("testNgVersion",
> version);
> surefire-its/src/test/java/org/apache/maven/surefire/its/jiras/Surefire1967CheckTestNgMethodParallelOrderingIT.java:
> .sysProp("testNgVersion", "7.3.0")
> surefire-its/src/test/java/org/apache/maven/surefire/its/jiras/Surefire1967CheckTestNgMethodParallelOrderingIT.java:
> .sysProp("testNgVersion", "6.10")
> surefire-its/src/test/java/org/apache/maven/surefire/its/jiras/Surefire1967CheckTestNgMethodParallelOrderingIT.java:
> .sysProp("testNgVersion", "6.2.1")
> surefire-its/src/test/java/org/apache/maven/surefire/its/jiras/Surefire376TestNgAfterSuiteFailureIT.java:
> .sysProp("testNgVersion", "5.7")
> surefire-its/src/test/java/org/apache/maven/surefire/its/jiras/Surefire377TestNgAndJUnitTogetherIT.java:
> .sysProp("testNgVersion", "5.7")
> surefire-its/src/test/java/org/apache/maven/surefire/its/jiras/Surefire377TestNgAndJUnitTogetherIT.java:
> .sysProp("testNgVersion", "5.7")
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
