[ 
https://issues.apache.org/jira/browse/MNG-7999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17805102#comment-17805102
 ] 

ASF GitHub Bot commented on MNG-7999:
-------------------------------------

gnodet commented on PR #1367:
URL: https://github.com/apache/maven/pull/1367#issuecomment-1884742836

   What about adding a specific exception inheriting `LookupException` for when 
the component is  not found when calling `<T> T lookup(Class<T> role)` ? 




> Confine Plexus as much as possible, switch to Lookup
> ----------------------------------------------------
>
>                 Key: MNG-7999
>                 URL: https://issues.apache.org/jira/browse/MNG-7999
>             Project: Maven
>          Issue Type: Task
>          Components: Core
>            Reporter: Tamas Cservenak
>            Assignee: Tamas Cservenak
>            Priority: Major
>             Fix For: 4.0.0, 4.0.0-alpha-11
>
>
> Confine plexus use in core as much as possible. Probably almost all uses may 
> be replaced with API Lookup.
> Cleanup unused members as well, I found at least two components:
> * org/apache/maven/lifecycle/DefaultLifecycleExecutor
> * org/apache/maven/lifecycle/internal/LifecycleStarter
> but I bet there are more...
> Given clients should _inject_ and not manually instantiate components, ctor 
> changes should be hidden from them (managed by DI). Hence, changes like these 
> are "safe" as long as client code "plays by the rules".



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to