rmannibucau commented on PR #240:
URL:
https://github.com/apache/maven-plugin-tools/pull/240#issuecomment-1891500550
> Especially it seems that two projects (tycho+apache-rat) that are using
the convention <projectname>-plugin getting the same resulting prefix (==
<projectname> ) so it can't be that random....
s/random/uncontrolled or unknown/
and this is the issue, when then the plugin wants to take control cause you
don't want to type my-plugin-foo or anything else then you break backward
compat of the runtime so better to adjust the *tooling* (build only, note there
is *no* breaking change for the runtime).
The fix is *always* trivial: grab your last release read your plugin.xml and
just configure it to be aligned.
> So obviously the assumption that anything that do not matches
*-maven-plugin *-maven-plugin got no prefix is wrong, you never get an empty
prefix as claimed in the ticket.
No, you can review the previous code, if the artifactId does not follow
maven convention then the heuristic is just failing and returns null leading to
no prefix in plugin.xml.
A common pattern I saw was to name the maven plugin "maven-plugin", then,
due to the `Pattern.compile("-?(maven|plugin)-?").replaceAll("")` usage in the
heuristic it was leading to no prefix.
Indeed we can relax a bit the fix Guillaume did to keep the heuristic and
warn the user it should be set explicitly to ensure it is under control but I
guess the best is just current code which is the most straight forward for
anyone, once the error message is explicit the fix is trivial for anyone and
there wouldn't be much discussion I think.
That said I would be ok if we do this change only for maven 4 and keep maven
3 as this but I think it goes in the right direction enhancing the quality of
the built plugins and the warning would just be as bothering as an error so
let's keep it an error for the final deliverable.
Side note: if you don't know the prefix you were using you can also rely on
the doc, as of today, since it is explicit there, you can review
https://tycho.eclipseprojects.io/doc/latest/tycho-compiler-plugin/plugin-info.html
for example.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
