[
https://issues.apache.org/jira/browse/MSHARED-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806748#comment-17806748
]
ASF GitHub Bot commented on MSHARED-1351:
-----------------------------------------
hboutemy commented on code in PR #93:
URL: https://github.com/apache/maven-filtering/pull/93#discussion_r1452231849
##########
src/main/java/org/apache/maven/shared/filtering/DefaultMavenResourcesFiltering.java:
##########
@@ -254,9 +255,15 @@ private File getTargetFile(File file) throws
MavenFilteringException {
Path destination = getDestinationFile(outputDirectory,
targetPath, "", mavenResourcesExecution)
.getAbsoluteFile()
.toPath();
+ String origin = basedir.relativize(
+ resourceDirectory.getAbsoluteFile().toPath())
+ .toString();
+ if (StringUtils.isEmpty(origin)) {
+ origin = "base directory";
Review Comment:
classical value is `.`, isn't it?
> Confusing message when copying resources from project's baseDir
> ---------------------------------------------------------------
>
> Key: MSHARED-1351
> URL: https://issues.apache.org/jira/browse/MSHARED-1351
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-filtering
> Affects Versions: maven-filtering-3.3.1
> Reporter: Abel Salgado Romero
> Priority: Minor
>
> When the project base dir is used as the origin path, the relativize in
> https://github.com/apache/maven-filtering/blob/dce786df4301dab6d51d1eab6bbb79e510327086/src/main/java/org/apache/maven/shared/filtering/DefaultMavenResourcesFiltering.java#L259
> resolves to empty string, resulting in nothing being displayed path after
> "from" in the console:
> ```
> Copying 118 resources from to target/generated-docs
> ```
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
