[ 
https://issues.apache.org/jira/browse/MSHARED-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807597#comment-17807597
 ] 

ASF GitHub Bot commented on MSHARED-1351:
-----------------------------------------

hboutemy commented on code in PR #93:
URL: https://github.com/apache/maven-filtering/pull/93#discussion_r1454778432


##########
src/test/java/org/apache/maven/shared/filtering/DefaultMavenResourcesFilteringTest.java:
##########
@@ -24,13 +24,10 @@
 import java.io.FileInputStream;
 import java.io.IOException;
 import java.nio.file.Files;
-import java.util.ArrayList;
-import java.util.Arrays;
-import java.util.Collections;
-import java.util.List;
-import java.util.Properties;
+import java.util.*;

Review Comment:
   please don't reformat this





> Confusing message when copying resources from project's baseDir
> ---------------------------------------------------------------
>
>                 Key: MSHARED-1351
>                 URL: https://issues.apache.org/jira/browse/MSHARED-1351
>             Project: Maven Shared Components
>          Issue Type: Improvement
>          Components: maven-filtering
>    Affects Versions: maven-filtering-3.3.1
>            Reporter: Abel Salgado Romero
>            Priority: Minor
>
> When the project base dir is used as the origin path, the relativize in 
> https://github.com/apache/maven-filtering/blob/dce786df4301dab6d51d1eab6bbb79e510327086/src/main/java/org/apache/maven/shared/filtering/DefaultMavenResourcesFiltering.java#L259
>  resolves to empty string, resulting in nothing being displayed path after 
> "from" in the console:
> ```
> Copying 118 resources from to target/generated-docs
> ```



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to