[ 
https://issues.apache.org/jira/browse/MNG-8026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17813933#comment-17813933
 ] 

ASF GitHub Bot commented on MNG-8026:
-------------------------------------

desruisseaux commented on code in PR #1391:
URL: https://github.com/apache/maven/pull/1391#discussion_r1477061174


##########
api/maven-api-core/src/main/java/org/apache/maven/api/DependencyScope.java:
##########
@@ -0,0 +1,125 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.api;
+
+import java.util.Collections;
+import java.util.Map;
+import java.util.stream.Collectors;
+import java.util.stream.Stream;
+
+import org.apache.maven.api.annotations.Experimental;
+import org.apache.maven.api.annotations.Immutable;
+import org.apache.maven.api.annotations.Nonnull;
+
+/**
+ * Dependency scope.
+ * <p>
+ * Implementation must have {@code equals()} and {@code hashCode()} 
implemented, so implementations of this interface
+ * can be used as keys.
+ *
+ * @since 4.0.0
+ */
+@Experimental
+@Immutable
+public enum DependencyScope {
+
+    /**
+     * None. Allows you to declare dependencies (for example to alter reactor 
build order) but in reality dependencies
+     * in this scope are not part of any build path scope.
+     */
+    NONE("none", false),
+
+    /**
+     * Empty scope.
+     */
+    EMPTY("", false),
+
+    /**
+     * Compile only.
+     */
+    COMPILE_ONLY("compile-only", false),
+
+    /**
+     * Compile.

Review Comment:
   I presume that we mean "compile, test and runtime"? (for clarifying the 
difference with `COMPILE_ONLY`).





> Maven should define from ground up scopes used with Resolver
> ------------------------------------------------------------
>
>                 Key: MNG-8026
>                 URL: https://issues.apache.org/jira/browse/MNG-8026
>             Project: Maven
>          Issue Type: Task
>            Reporter: Tamas Cservenak
>            Assignee: Tamas Cservenak
>            Priority: Major
>             Fix For: 4.0.0, 4.0.0-alpha-13
>
>
> See MRESOLVER-471, it is actually role of Maven (as a resolver consumer 
> project) to define all these things:
>  * supported scopes
>  * transformations of scopes to build path scopes
>  * fine tune conflict resolution and related things (in session)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to