[
https://issues.apache.org/jira/browse/MSCMPUB-63?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17815699#comment-17815699
]
ASF GitHub Bot commented on MSCMPUB-63:
---------------------------------------
michael-o commented on PR #29:
URL:
https://github.com/apache/maven-scm-publish-plugin/pull/29#issuecomment-1934248384
That easy? No test necessary? Do ITs cover it already?
> Rely on DefaultScmRepositoryConfigurator from maven-release for extracting
> credentials from settings.xml
> --------------------------------------------------------------------------------------------------------
>
> Key: MSCMPUB-63
> URL: https://issues.apache.org/jira/browse/MSCMPUB-63
> Project: Maven SCM Publish Plugin
> Issue Type: Improvement
> Reporter: Konrad Windszus
> Assignee: Konrad Windszus
> Priority: Major
>
> Currently the logic to extract (encrypted) server credentials from Maven
> settings is duplicated in
> https://github.com/apache/maven-scm-publish-plugin/blob/823fdfba3f5034bca2f337b8754a1e923d16a8a9/src/main/java/org/apache/maven/plugins/scmpublish/AbstractScmPublishMojo.java#L331-L351
> (would happen in
> https://github.com/apache/maven-release/blob/0f5e7a14ac7df9861ee7fc08a6ed8ac9fb18321b/maven-release-manager/src/main/java/org/apache/maven/shared/release/scm/DefaultScmRepositoryConfigurator.java#L80
> implicitly). Therefore the according code should be removed from the
> {{maven-scm-publish-plugin}} and just the server id passed to the
> {{ScmRepositoryConfigurator}}. That would potentially also consider private
> keys.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
