[
https://issues.apache.org/jira/browse/MRESOLVER-494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17816912#comment-17816912
]
ASF GitHub Bot commented on MRESOLVER-494:
------------------------------------------
cstamas commented on code in PR #428:
URL: https://github.com/apache/maven-resolver/pull/428#discussion_r1487436991
##########
maven-resolver-util/src/main/java/org/eclipse/aether/util/graph/manager/AbstractDependencyManager.java:
##########
@@ -199,25 +199,27 @@ public DependencyManagement manageDependency(Dependency
dependency) {
}
management.setScope(scope);
- if (!systemScopePredicate.test(scope)
- &&
dependency.getArtifact().getProperty(ArtifactProperties.LOCAL_PATH, null) !=
null) {
+ if (!systemScopeHandler.isSystemScope(scope)
+ && systemScopeHandler.getSystemPath(
+
dependency.getArtifact().getProperties())
+ != null) {
Map<String, String> properties =
new
HashMap<>(dependency.getArtifact().getProperties());
- properties.remove(ArtifactProperties.LOCAL_PATH);
+ systemScopeHandler.setSystemPath(properties, null);
management.setProperties(properties);
}
}
- if ((systemScopePredicate.test(scope))
- || (scope == null &&
systemScopePredicate.test(dependency.getScope()))) {
+ if ((systemScopeHandler.isSystemScope(scope))
+ || (scope == null &&
systemScopeHandler.isSystemScope(dependency.getScope()))) {
String localPath = managedLocalPaths.get(key);
Review Comment:
systemScopeHandler is session scoped, while managedLocalPaths is per mgr,
and mgr is created as needed (see "deriveChildManager"), so unsure how could we
do that.
> LOCAL_PATH Artifact property really belongs to "system" scope (or is at least
> very related to it)
> -------------------------------------------------------------------------------------------------
>
> Key: MRESOLVER-494
> URL: https://issues.apache.org/jira/browse/MRESOLVER-494
> Project: Maven Resolver
> Issue Type: Improvement
> Components: Resolver
> Reporter: Tamas Cservenak
> Assignee: Tamas Cservenak
> Priority: Major
> Fix For: 2.0.0-alpha-8, 2.0.0
>
>
> LOCAL_PATH Artifact property really belongs to "system" scope (or is at least
> very related to it).
> It may need to be removed as well?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
