[
https://issues.apache.org/jira/browse/MJAR-301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17818015#comment-17818015
]
S L commented on MJAR-301:
--------------------------
Hello, thanks for the quick feedback!
Ok, fine with me if you want to be explicit and want to avoid certain edge
cases.
However IMHO the 2024-02-15T13:54:59+0100 is following ISO 8601 standard.
Refer for example to the java doc
[https://docs.oracle.com/javase/8/docs/api/java/text/SimpleDateFormat.html#iso8601timezone]
[https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/text/SimpleDateFormat.html#iso8601timezone]
Both docs mention the support for the following three cases:
{code:java}
OneLetterISO8601TimeZone:
Sign TwoDigitHours
Z
TwoLetterISO8601TimeZone:
Sign TwoDigitHours Minutes
Z
ThreeLetterISO8601TimeZone:
Sign TwoDigitHours : Minutes
Z {code}
The 2024-02-15T13:54:59+0100 follows the TwoLetterISO8601TimeZone. Only the
ThreeLetterISO8601TimeZone can be currently processed.
Similar to what wikipedia claims
[https://en.wikipedia.org/wiki/ISO_8601#Time_zone_designators]:
{code:java}
<time>Z
<time>±hh:mm
<time>±hhmm
<time>±hh {code}
The 2024-02-15T13:54:59+0100 follows <time>±hhmm and therefore should be
supported.
> maven jar plugin does not support all cases of ISO 8601 dates for
> project.build.outputTimestamp
> -----------------------------------------------------------------------------------------------
>
> Key: MJAR-301
> URL: https://issues.apache.org/jira/browse/MJAR-301
> Project: Maven JAR Plugin
> Issue Type: Bug
> Affects Versions: 3.3.0
> Reporter: S L
> Priority: Major
> Attachments: git-plugin-timestamp-problem-demo_minimal.zip
>
>
> Originally reported in
> [https://github.com/git-commit-id/git-commit-id-maven-plugin/issues/674] by
> "Interessierter".
>
> May or may not be related to https://issues.apache.org/jira/browse/MJAR-300.
>
> The support for reproducible builds (ISO 8601 date formats) should have been
> added to the maven-jar-plugin in version 3.2.X (via
> https://issues.apache.org/jira/browse/MJAR-263).
>
> The documentation of the maven-jar-plugin
> ([https://github.com/apache/maven-jar-plugin/blob/63f9c982d49f046519088490d7a8af5a7cd647fb/src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java#L144])
> even claims it can process ISO 8601 date formats as input for
> project.build.outputTimestamp, however there seems to be some cases that are
> unsupported.
>
> Not supported:
> 2022-02-12T15:30:45
> 2024-02-15T13:54:59+0100 (note with an extra ':' like '+01:00' this works)
>
> Not supported edge cases:
> 2022-W06
> 2022-W06-5
> 2022-W06-5T15:30:45
> 2019-03-26T14:00.9Z
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
