[
https://issues.apache.org/jira/browse/MSHARED-1364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17827721#comment-17827721
]
Konrad Windszus commented on MSHARED-1364:
------------------------------------------
I would recommend copy it to
https://github.com/apache/maven-doxia/tree/e01880801ca1283b86205e2f7064b9b4dbc84d54/doxia-sink-api/src/main/java/org/apache/maven/doxia/sink
(and at the same time deprecate the other one).
> AbstractMavenReportRenderer should not depend on Doxia impl classes
> -------------------------------------------------------------------
>
> Key: MSHARED-1364
> URL: https://issues.apache.org/jira/browse/MSHARED-1364
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-reporting-impl
> Affects Versions: maven-reporting-impl-4.0.0-M13
> Reporter: Konrad Windszus
> Priority: Major
>
> The classes in package {{o.a.m.doxia.sink.impl}} should by definition not be
> considered stable API (and therefore only consumed from Doxia classes
> internally).
> However
> {{https://github.com/apache/maven-reporting-impl/blob/72181306bb0e12eed50c4ba4aec98dd76499df39/src/main/java/org/apache/maven/reporting/AbstractMavenReportRenderer.java#L47}}
> depends on some internal constants.
> This is dangerous, as those constants were removed in the context of
> DOXIA-685. Although constants are inlined during compile time, the evaluation
> of those constants vanished as well, so using them has no longer any effect.
> Reporting Impl should only rely on stable Doxia API to achieve a better
> decoupling.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
