michael-o commented on code in PR #206:
URL: https://github.com/apache/maven-doxia/pull/206#discussion_r1546466352
##########
doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/BufferingSinkProxyFactory.java:
##########
@@ -83,9 +85,16 @@ public Object invoke(Object proxy, Method method, Object[]
args) throws Throwabl
bufferedInvocations.clear();
} else if (method.equals(GET_BUFFERED_SINK_METHOD)) {
return delegate;
+ } else if (method.equals(GET_DOCUMENT_LOCATOR_METHOD)) {
+ return delegate.getDocumentLocator();
} else {
bufferedInvocations.add(new MethodWithArguments(method, args));
}
+ if (method.getReturnType() != Void.TYPE) {
+ throw new IllegalStateException(
+ "BufferingSinkProxy only works for methods returning
void, but given method " + method
+ + " requires another return type");
+ }
Review Comment:
Would it make sense to write out the actual method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
