[
https://issues.apache.org/jira/browse/MARTIFACT-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17833405#comment-17833405
]
ASF GitHub Bot commented on MARTIFACT-59:
-----------------------------------------
hboutemy commented on PR #30:
URL:
https://github.com/apache/maven-artifact-plugin/pull/30#issuecomment-2033572703
> I would be happy if true but what did you do different from me?
I don't know what you did, you talked but did not share any output. I ran
check-buildplan against latest release of moditect for 3.5.0 and 3.5.1: see
https://gist.github.com/hboutemy/cca5a94c6f7a9bc65023a31c31d3308f
> Also code is more on my side than yours for now - see this PR for details
- so I don't understand what you're trying to say for now.
this code does some magic about "injecting": I don't know what injecting
means, from unit test, I don't get what CLI command it is related to: `mvn
-Dproject.nuild.outputTimestamp=set`? How is it related to using Git commit id
configured in pom.xml = what we are discussing?
Yes, there is code with vague explanations: from the very beginning, I'm
asking for concrete tests showing what is tried to be solved, given the single
"tolerate injected timestamp value" description that is given does not explain
at all.
> artifact plugin should tolerate injected project.build.outputTimestamp
> ----------------------------------------------------------------------
>
> Key: MARTIFACT-59
> URL: https://issues.apache.org/jira/browse/MARTIFACT-59
> Project: Maven Artifact Plugin
> Issue Type: Improvement
> Reporter: Romain Manni-Bucau
> Priority: Minor
> Labels: pull-request-available
>
> Goal is to not log
> {code:java}
> Reproducible Build not activated by project.build.outputTimestamp property:
> see https://maven.apache.org/guides/mini/guide-reproducible-builds.html {code}
> when the project is actually set but computed from another property and not
> fail (check mojo) when the setup is the same.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
