[ https://issues.apache.org/jira/browse/MGPG-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836468#comment-17836468 ]
ASF GitHub Bot commented on MGPG-125: ------------------------------------- slawekjaranowski commented on code in PR #95: URL: https://github.com/apache/maven-gpg-plugin/pull/95#discussion_r1562201582 ########## src/it/sign-release-best-practices/verify.groovy: ########## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +var artifactDir = new File(localRepositoryPath, "org/apache/maven/its/gpg/sr/test/1.0") + +var expectedFiles = [ + "test-1.0.pom", + "test-1.0.pom.asc", + "test-1.0.jar", + "test-1.0.jar.asc", + "test-1.0-sources.jar", + "test-1.0-sources.jar.asc" +] + +for (String expectedFile : expectedFiles) { + var file = new File(artifactDir, expectedFile) + + println "Checking for existence of $file" + + if (!file.isFile()) { Review Comment: `assert file.isFile()` > Due to default value of gpg.passphraseServerId, bestPractices=true will > always fail > ----------------------------------------------------------------------------------- > > Key: MGPG-125 > URL: https://issues.apache.org/jira/browse/MGPG-125 > Project: Maven GPG Plugin > Issue Type: Bug > Affects Versions: 3.2.3 > Reporter: Benjamin Marwell > Assignee: Tamas Cservenak > Priority: Critical > Fix For: 3.2.4 > > > Running gpg-plugin with best practices from the CLI, it will always fail > since gpg.passphraseServerId does have a default value set. > See: > https://github.com/apache/maven-gpg-plugin/blob/master/src/main/java/org/apache/maven/plugins/gpg/AbstractGpgMojo.java#L140 > CC [~cstamas] -- This message was sent by Atlassian Jira (v8.20.10#820010)