[
https://issues.apache.org/jira/browse/MCOMPILER-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836831#comment-17836831
]
ASF GitHub Bot commented on MCOMPILER-588:
------------------------------------------
MidNight-er opened a new pull request, #233:
URL: https://github.com/apache/maven-compiler-plugin/pull/233
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MCOMPILER) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [ x] Each commit in the pull request should have a meaningful subject
line and body.
- [ x] Format the pull request title like `[MCOMPILER-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `MCOMPILER-XXX` with the appropriate JIRA issue.
Best practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
- [x ] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [x ] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [ x] You have run the integration tests successfully (`mvn -Prun-its
clean verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ x] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [x ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
> JUnit4 test framework to JUnit5 migration
> -----------------------------------------
>
> Key: MCOMPILER-588
> URL: https://issues.apache.org/jira/browse/MCOMPILER-588
> Project: Maven Compiler Plugin
> Issue Type: Improvement
> Reporter: Mikhail Deviatov
> Priority: Major
>
> We have JUnit5 test framework for a long time.
> It have modular architecture, good support in IDE and quite fast. It would be
> good to add support JUnit5 to the project.
> The problem is that there are 2 library used for testing in project
> *maven-plugin-testing-harness* and *org.eclipse.sisu.plexus* and they both
> don't have JUnit5 support.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
