[
https://issues.apache.org/jira/browse/MSHADE-471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839248#comment-17839248
]
ASF GitHub Bot commented on MSHADE-471:
---------------------------------------
rmannibucau commented on PR #220:
URL:
https://github.com/apache/maven-shade-plugin/pull/220#issuecomment-2067699038
* reproducible tests don't check the time is accurate whatever the timezone
is (it is the opposite as shown by the test)
* UTC tests do not use UTC time so they are iso other tests as of today
* proves the time management is wrong in shade dependency inclusion feature
which creates issues so we need to revisit it either enabling to configure the
timezone per dependency or using the UTC time when it is available (indeed it
does not enable reproducible builds if you build under another timezone by
design but it is expected IMHO since otherwise code depending on jar resources
time are just broken)
> still timestamp issues with timezones (DST?)
> --------------------------------------------
>
> Key: MSHADE-471
> URL: https://issues.apache.org/jira/browse/MSHADE-471
> Project: Maven Shade Plugin
> Issue Type: Bug
> Affects Versions: 3.5.2
> Reporter: Herve Boutemy
> Assignee: Herve Boutemy
> Priority: Major
> Fix For: 3.5.3
>
>
> MSHADE-420 is incomplete, problems still appear like
> {noformat}1 / 1
> target/reference/eu.maveniverse.maven.plugins/toolbox-0.1.5-cli.jar
> toolbox/target/toolbox-0.1.5-cli.jar
> --- target/reference/eu.maveniverse.maven.plugins/toolbox-0.1.5-cli.jar
> +++ toolbox/target/toolbox-0.1.5-cli.jar
> ├── zipinfo {}
> │ @@ -735,96 +735,96 @@
> │ -rw---- 2.0 fat 50 bl defN 24-Jan-23 12:20
> META-INF/maven/org.jline/jline/pom.properties
> │ --rw---- 2.0 fat 0 bl defN 23-Oct-12 07:38
> META-INF/native-image/jansi/
> │ --rw---- 2.0 fat 12491 bl defN 23-Oct-12 07:38
> META-INF/native-image/jansi/jni-config.json
> ...
> │ --rw---- 2.0 fat 17329 bl defN 23-Oct-12 07:38
> META-INF/maven/org.fusesource.jansi/jansi/pom.xml
> │ --rw---- 2.0 fat 60 bl defN 23-Oct-12 07:38
> META-INF/maven/org.fusesource.jansi/jansi/pom.properties
> │ +-rw---- 2.0 fat 0 bl defN 23-Oct-12 06:38
> META-INF/native-image/jansi/
> │ +-rw---- 2.0 fat 12491 bl defN 23-Oct-12 06:38
> META-INF/native-image/jansi/jni-config.json
> ...
> │ +-rw---- 2.0 fat 17329 bl defN 23-Oct-12 06:38
> META-INF/maven/org.fusesource.jansi/jansi/pom.xml
> │ +-rw---- 2.0 fat 60 bl defN 23-Oct-12 06:38
> META-INF/maven/org.fusesource.jansi/jansi/pom.properties
> │ -rw---- 2.0 fat 0 bl defN 24-Apr-11 20:18
> eu/maveniverse/maven/toolbox/shared/
> {noformat}
> https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/eu/maveniverse/maven/toolbox/README.md
> (fixed since then by using a TZ, but initial UTC shows the issue)
> looks related to DST: probably need to apply what has been done in
> plexus-archiver
> https://github.com/codehaus-plexus/plexus-archiver/commit/b9ea3bf0e4c25c0a5cf1bcbc76e691067003dc36
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
