[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839939#comment-17839939 ]
ASF GitHub Bot commented on DOXIASITETOOLS-336: ----------------------------------------------- hboutemy commented on code in PR #150: URL: https://github.com/apache/maven-doxia-sitetools/pull/150#discussion_r1575656039 ########## doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/SiteRenderingContext.java: ########## @@ -271,7 +290,7 @@ public void addSiteDirectory(File siteDirectory) { * * @return List of site directories files. */ - public List<File> getSiteDirectories() { + public List<SiteDirectory> getSiteDirectories() { Review Comment: yes, Doxia Sitetools is only used by Maven Site plugin: binary compatibility is not really a topic, particularly when we are working on 2.0 milestones of Doxia Sitetools > Make SiteRenderingContext#siteDirectories editable aware > -------------------------------------------------------- > > Key: DOXIASITETOOLS-336 > URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-336 > Project: Maven Doxia Sitetools > Issue Type: Improvement > Components: Site renderer > Affects Versions: 2.0.0-M16 > Reporter: Michael Osipov > Assignee: Michael Osipov > Priority: Major > Fix For: 2.0.0, 2.0.0-M18 > > > Right now you cannot qualify a {{siteDirectory}} whether the content is > editable or generated. You need to perform multiple calls with distinct > {{SiteRenderingContexts}}. This causes computational overhead is hacks like > MSITE-723. -- This message was sent by Atlassian Jira (v8.20.10#820010)