[ 
https://issues.apache.org/jira/browse/MBUILDCACHE-87?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840929#comment-17840929
 ] 

ASF GitHub Bot commented on MBUILDCACHE-87:
-------------------------------------------

AlexanderAshitkin commented on PR #146:
URL: 
https://github.com/apache/maven-build-cache-extension/pull/146#issuecomment-2078015471

   The increased entropy could be a potential vector of regression. Though the 
feature looks correct to me and should be on by default, there should be a way 
to disable it if it doesn't work as expected.  Please add a configuration flag 
to turn it off. Ideally, it should be a per-plugin flag.




> Checksum should consider plugin dependencies
> --------------------------------------------
>
>                 Key: MBUILDCACHE-87
>                 URL: https://issues.apache.org/jira/browse/MBUILDCACHE-87
>             Project: Maven Build Cache Extension
>          Issue Type: Improvement
>            Reporter: RĂ©da Housni Alaoui
>            Priority: Major
>              Labels: pull-request-available
>
> I have a multi module project where module A is used as a dependency of 
> maven-dependency-plugin:unpack declared in module B.
> {{buildinfo.xml}} of module B does not consider module A as a dependency.
> Maybe something similar to 
> https://github.com/apache/maven-build-cache-extension/blob/6eb05e61fdfa7be1ad44cf6afc13958b0c6ea4a6/src/main/java/org/apache/maven/buildcache/checksum/MavenProjectInput.java#L602
>  should be added for plugin dependencies?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to