michael-o commented on code in PR #878:
URL: https://github.com/apache/maven/pull/878#discussion_r1582075212


##########
apache-maven/src/assembly/shared/mvnvalidate.ps1:
##########
@@ -0,0 +1,7 @@
+# check mvn home
+$MAVEN_HOME = (Get-Item $PSScriptRoot).Parent
+
+# check if maven command exists
+if (-not (Test-path "$MAVEN_HOME\bin\mvn.ps1")) {
+    Write-Error -Message "Maven command ($MAVEN_HOME\bin\mvn.ps1) cannot be 
found" -ErrorAction Stop
+}

Review Comment:
   But how can this happen at all? This is a chicken-and-egg issue. This block 
is part of the merged `mvn.ps1`. If the file is not present that check will 
never happen, no? This confuses me.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to