olamy commented on code in PR #238:
URL:
https://github.com/apache/maven-compiler-plugin/pull/238#discussion_r1588461150
##########
.github/workflows/maven-verify.yml:
##########
@@ -28,7 +28,9 @@ jobs:
with:
# maven-args: "-Dinvoker.parallelThreads=2" cannot do this as this
generate some concurrent download issues
jdk-distribution-matrix: '[ "temurin", "zulu", "microsoft",
"adopt-openj9" ]'
- ff-jdk: "20"
- jdk-matrix: '[ "8", "11", "17", "20" ]'
- matrix-exclude: '[{ "jdk": "8", "distribution": "microsoft"},{ "jdk":
"20", "distribution": "microsoft"},{ "jdk": "20", "distribution":
"adopt-openj9"},]'
- maven-matrix: '[ "3.6.3", "3.8.8", "3.9.5" ]' # Maven versions matrix
for verify builds
+ matrix-exclude: '[
Review Comment:
the goal was to have a maximum of jdk to be tested as compiling can be
highly dependant of the used jdk.
so with this we are really reducing the coverage.
could we keep testing on 11 maybe?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
