[
https://issues.apache.org/jira/browse/MPLUGIN-522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844198#comment-17844198
]
ASF GitHub Bot commented on MPLUGIN-522:
----------------------------------------
gnodet commented on PR #282:
URL:
https://github.com/apache/maven-plugin-tools/pull/282#issuecomment-2097717570
> I think enforcing prerequisites is a good thing and the default match for
99% of the cases. For other cases just overwrite with explicit values. Not
stating prerequisites should no longer be supported because it is frustratring
for users to figure out the implicit prerequisites through trial and error...
Putting prerequisites which are greater than the one actually used to build
are, at first, very weird. For example, if you project requires jdk 11, you
build with jdk 11, test it with jdk 11, but your prerequisites ends up with jdk
22... ? That's really unexpected, and the user has no real knowledge about the
value used.
The prerequisites should not be higher than the target JDK.
> The auto prerequisites are way to aggressive
> --------------------------------------------
>
> Key: MPLUGIN-522
> URL: https://issues.apache.org/jira/browse/MPLUGIN-522
> Project: Maven Plugin Tools
> Issue Type: Bug
> Components: Plugin Plugin
> Reporter: Tamas Cservenak
> Priority: Major
>
> IMHO the implementation done in MPLUGIN-425 and MPLUGIN-424 are wrong.
> They are way too aggresive and violate backward compatibility: if new feature
> is not explicitly set by user, code should not "come up" with some automatic
> value. By having the value not set simply means user does not want to use it.
> This is especially true for (maven or java) prerequisite, as it creates HARD
> BREAKAGE if not met. Use of prerequisite is opt-in, but now it is FORCED onto
> user.
> [~kwin]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
