[
http://jira.codehaus.org/browse/DOXIA-133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_104017
]
Vincent Siveton commented on DOXIA-133:
---------------------------------------
>From an API point of view, I am not at ease with Doxia.isXmlSource( String
>parserId ). I propose you a better approach which sounds better for me:
{code:title=Doxia.java|borderStyle=solid}
...
/**
* @param parserId Identifier for the parser to use.
* @return the parser defining for parserId.
* @throws ParserNotFoundException if no parser could be found
* for the given id.
*/
Parser getParser( String parserId )
throws ParserNotFoundException;
...
{code}
{code:title=Parser.java|borderStyle=solid}
...
/**
* @return xml for xml parser, text for text parser
*/
String getType();
...
{code}
{code:title=DefaultSiteRenderer.java|borderStyle=solid}
...
boolean isXml = doxia.getParser( renderingContext.getParserId()
).getType().equals("xml");
...
{code}
Thoughts?
> default XML encoding (UTF-8) or XML encoding set in XML files is ignored:
> inputEncoding is used instead
> -------------------------------------------------------------------------------------------------------
>
> Key: DOXIA-133
> URL: http://jira.codehaus.org/browse/DOXIA-133
> Project: Maven Doxia
> Issue Type: Bug
> Components: Core, Module - Docbook Simple, Module - Fml, Module -
> Xdoc, Module - Xhtml, Site Renderer
> Affects Versions: 1.0-alpha-8
> Reporter: Herve Boutemy
> Fix For: 1.0-alpha-9
>
> Attachments: DOXIA-133_doxia-siterenderer.diff, DOXIA-133_doxia.diff,
> DOXIA-133_doxia.diff, DOXIA-133_doxia.diff
>
>
> Encoding can be specified per file, in the XML header: <?xml version="1.0"
> encoding="xxx"?>, or defaults to UTF-8
> But DefaultSiteRenderer class always read files with inputEncoding: {{reader
> = new InputStreamReader( new FileInputStream( fullPathDoc ),
> context.getInputEncoding() );}}
> When the source file is XML (xdoc, xhtml), should use XmlReader from
> PLXUTILS-11 to detect the XML stream encoding instead.
> Test case included in MSITE-239, site-plugin-test14
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
