slawekjaranowski commented on code in PR #228:
URL: 
https://github.com/apache/maven-shade-plugin/pull/228#discussion_r1616933185


##########
src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java:
##########
@@ -393,6 +392,36 @@ public class ShadeMojo extends AbstractMojo {
     @Parameter(defaultValue = "false")
     private boolean skip;
 
+    /**
+     * Extra JAR files to infuse into shaded result.
+     * <p>
+     * One can add here "extra JARs", to be worked into the resulting shaded 
JAR. The listed JAR files must exist.
+     * Extra JARs will be processed in same way as main JAR (if any): applied 
relocation, resource transformers
+     * but not filtering.
+     * <p>
+     * Note: this feature should be used lightly, is not meant as ability to 
replace dependency hull! It is more
+     * just a feature to be able to slightly "differentiate" shaded JAR from 
main only.
+     *
+     * @since 3.6.0
+     */
+    @Parameter
+    private List<File> extraJars;

Review Comment:
   we should add what is the item ... I guess that is a path to jar file



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to