[ 
http://jira.codehaus.org/browse/WAGON-73?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_104144
 ] 

Brian Fox commented on WAGON-73:
--------------------------------

I applied the relevant patches and committed to a branch here: 
https://svn.apache.org/repos/asf/maven/wagon/branches/WAGON-73

Patches are easier to apply if there is one patch combining all changes 
throughout the life of the issue. The patch should be created with svn from the 
root of the project where the changes are to be made...otherwise the files need 
to be hand-edited before applying. For example:

{noformat}
Index: 
/home/philw/mavenide/wagon-manager/src/main/java/org/apache/maven/wagon/manager/MirroredWagon.java
===================================================================
--- 
/home/philw/mavenide/wagon-manager/src/main/java/org/apache/maven/wagon/manager/MirroredWagon.java
  (revision 519885)
+++ 
/home/philw/mavenide/wagon-manager/src/main/java/org/apache/maven/wagon/manager/MirroredWagon.java
  (working copy)
{noformat}

should be

{noformat}
Index: 
wagon-manager/src/main/java/org/apache/maven/wagon/manager/MirroredWagon.java
===================================================================
--- 
wagon-manager/src/main/java/org/apache/maven/wagon/manager/MirroredWagon.java   
    (revision 519885)
+++ 
wagon-manager/src/main/java/org/apache/maven/wagon/manager/MirroredWagon.java   
    (working copy)

{noformat}

> MirroredWagon infinite loop
> ---------------------------
>
>                 Key: WAGON-73
>                 URL: http://jira.codehaus.org/browse/WAGON-73
>             Project: wagon
>          Issue Type: Bug
>            Reporter: Phillip Webb
>            Priority: Critical
>             Fix For: 2.0
>
>         Attachments: returnsonmirroredwagon.patch, 
> WAGON-73-ConnectAndGetTest.patch, WagonManagerTest.java.patch
>
>
> The MirroredWagon class includes a get method that runs into an infinite loop.
> I think a return is required after this.impl.get( resource, destination );
>     public void get( String resource, File destination )
>         throws TransferFailedException, ResourceDoesNotExistException, 
> AuthorizationException
>     {
>         try
>         {
>             while ( true )
>             {
>                 try
>                 {
>                     this.impl.get( resource, destination );
>                 }
>                 catch ( TransferFailedException e )
>                 {
>                     nextMirror();
>                 }
>             }
>         }
>         catch ( ExhaustedMirrorsException e )
>         {
>         }
>     }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to