[ 
https://issues.apache.org/jira/browse/MDEP-799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850701#comment-17850701
 ] 

ASF GitHub Bot commented on MDEP-799:
-------------------------------------

elharo commented on code in PR #398:
URL: 
https://github.com/apache/maven-dependency-plugin/pull/398#discussion_r1620629551


##########
src/main/java/org/apache/maven/plugins/dependency/tree/TreeMojo.java:
##########
@@ -86,30 +84,6 @@ public class TreeMojo extends AbstractMojo {
     @Parameter(property = "outputEncoding", defaultValue = 
"${project.reporting.outputEncoding}")
     private String outputEncoding;
 
-    /**
-     * Contains the full list of projects in the reactor.
-     */
-    @Parameter(defaultValue = "${reactorProjects}", readonly = true, required 
= true)

Review Comment:
   does this cause problems for existing projects that set these?



##########
src/main/java/org/apache/maven/plugins/dependency/tree/TreeMojo.java:
##########
@@ -133,7 +107,8 @@ public class TreeMojo extends AbstractMojo {
 
     /**
      * If specified, this parameter will cause the dependency tree to be 
written using the specified format. Currently
-     * supported format are: <code>text</code> (default), <code>dot</code>, 
<code>graphml</code> and <code>tgf</code>.
+     * supported format are: <code>text</code> (default), <code>dot</code>, 
<code>graphml</code>, <code>tgf</code>

Review Comment:
   format --> formats





> improve mvn dependency:tree - add optional JSON output of the results
> ---------------------------------------------------------------------
>
>                 Key: MDEP-799
>                 URL: https://issues.apache.org/jira/browse/MDEP-799
>             Project: Maven Dependency Plugin
>          Issue Type: New Feature
>          Components: tree
>            Reporter: Zhenxu Ke
>            Assignee: Elliotte Rusty Harold
>            Priority: Major
>             Fix For: 3.7.0
>
>
> I'd like to add an output type JSON, will open a pull request soon



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to