[ 
https://issues.apache.org/jira/browse/MPLUGIN-508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850867#comment-17850867
 ] 

ASF GitHub Bot commented on MPLUGIN-508:
----------------------------------------

gnodet commented on code in PR #286:
URL: 
https://github.com/apache/maven-plugin-tools/pull/286#discussion_r1621444430


##########
maven-plugin-plugin/src/it/v4api/src/main/java/org/apache/maven/its/v4api/FirstMojo.java:
##########
@@ -38,15 +37,12 @@
  * Test mojo for the v4 api plugin descriptor generation.
  * This mojo is not actually runnable because:
  *  - it's using a custom lifecycle which is not defined
- *  - it has a @Component dependency on ArtifactInstaller (hint=test) which 
does not exist
+ *  - it has a @Inject dependency on ArtifactInstaller (hint=test) which does 
not exist
  *
  * @since 1.2
  */
-@Mojo(
-        name = "first",
-        requiresDependencyResolution = ResolutionScope.TEST,
-        defaultPhase = LifecyclePhase.INTEGRATION_TEST)
-@Execute(phase = LifecyclePhase.GENERATE_SOURCES, lifecycle = "cobertura")
+@Mojo(name = "first", defaultPhase = "integration-test")
+@Execute(phase = "generate-sources", lifecycle = "cobertura")
 public class FirstMojo implements org.apache.maven.api.plugin.Mojo {

Review Comment:
   I raised https://issues.apache.org/jira/browse/MNG-8134





> Upgrade to Maven 4.x
> --------------------
>
>                 Key: MPLUGIN-508
>                 URL: https://issues.apache.org/jira/browse/MPLUGIN-508
>             Project: Maven Plugin Tools
>          Issue Type: New Feature
>    Affects Versions: 3.12.0
>            Reporter: Guillaume Nodet
>            Assignee: Guillaume Nodet
>            Priority: Major
>             Fix For: 4.0.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to