michael-o commented on code in PR #141: URL: https://github.com/apache/maven-checkstyle-plugin/pull/141#discussion_r1631430729
########## src/main/java/org/apache/maven/plugins/checkstyle/AbstractCheckstyleReport.java: ########## @@ -26,22 +26,24 @@ import java.io.OutputStream; import java.nio.file.Path; import java.util.ArrayList; +import java.util.Collections; import java.util.List; import java.util.Locale; import java.util.Map; +import com.puppycrawl.tools.checkstyle.AbstractAutomaticBean.OutputStreamOptions; Review Comment: > If we broke compile compatibility, then I don't know how you have a choice but to choose which version you will support. We continue to use maven plugin, even in our snapshot, so from our perspective we still have runtime compatibility with the old version of the plugin. I didn't say that you broke it. You simply haven't thought about it. The PR I have provided is just a band-aid solution until I can lift the requirement. With the introductio of the `SarifLogger` in the plugin it does not work anymore. I have basically two options to make users happy: * Hope that you will merge and release 10.18.0 * Revert the `SarifLogger` I try to cover as many people as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
