michael-o commented on code in PR #141: URL: https://github.com/apache/maven-checkstyle-plugin/pull/141#discussion_r1631410232
########## src/main/java/org/apache/maven/plugins/checkstyle/AbstractCheckstyleReport.java: ########## @@ -26,22 +26,24 @@ import java.io.OutputStream; import java.nio.file.Path; import java.util.ArrayList; +import java.util.Collections; import java.util.List; import java.util.Locale; import java.util.Map; +import com.puppycrawl.tools.checkstyle.AbstractAutomaticBean.OutputStreamOptions; Review Comment: Tried, this only works if you compile against 10.x, but does not work if you compile against 9.x and want to have upwards compat because of that. @rnveach I totally understand your point, but I would expect deprecated stuff to be consistent to some extend. I cannot update the plugin to 10.x at the moment. I have raised a PR (https://github.com/checkstyle/checkstyle/pull/14954) and it works with current plugin by swapping the dep w/o changing any code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
