[ 
https://issues.apache.org/jira/browse/MNG-7194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853591#comment-17853591
 ] 

ASF GitHub Bot commented on MNG-7194:
-------------------------------------

pzygielo opened a new pull request, #1570:
URL: https://github.com/apache/maven/pull/1570

   (no comment)




> PluginParameterExpressionEvaluator incorrectly interpolates unknown 
> subexpression
> ---------------------------------------------------------------------------------
>
>                 Key: MNG-7194
>                 URL: https://issues.apache.org/jira/browse/MNG-7194
>             Project: Maven
>          Issue Type: Bug
>          Components: Inheritance and Interpolation
>            Reporter: Robert Scholte
>            Priority: Minor
>
> The PluginParameterExpressionEvaluator evaluate(String,Class)-method ends 
> like this:
> {code:java}
>         if ( value instanceof String )
>         {
>             // TODO: without #, this could just be an evaluate call...
>             String val = (String) value;
>             int exprStartDelimiter = val.indexOf( "${" );
>             if ( exprStartDelimiter >= 0 )
>             {
>                 if ( exprStartDelimiter > 0 )
>                 {
>                     value = val.substring( 0, exprStartDelimiter ) + 
> evaluate( val.substring( exprStartDelimiter ) );
>                 }
>                 else
>                 {
>                     value = evaluate( val.substring( exprStartDelimiter ) );
>                 }
>             }
>         }
> {code}
> Assume that pre${unknown} needs to be evaluated and {{unknown}} does not 
> exist, the result well be "{{prenull}}"
> Just ${unknown} evaluates to null, but because there's no String concat it 
> will be a real null.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to