[
https://issues.apache.org/jira/browse/MSHARED-1412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated MSHARED-1412:
-------------------------------------
Description:
The default implementation of {{getDefaultFilterWrappers}} always returns a
single element list containing a {{Wrapper}}
(https://github.com/apache/maven-filtering/blob/9d528d0871d93e317ae21a4b6922cd795502364c/src/main/java/org/apache/maven/shared/filtering/BaseFilter.java#L178).
That Wrapper's Interpolator should be customizable with regards to
#
[ValueSource|https://github.com/codehaus-plexus/plexus-interpolation/blob/7f8e0920ea9b65e61457d2cd14ed31c7ffe67044/src/main/java/org/codehaus/plexus/interpolation/Interpolator.java#L33]
and
#
[InterpolationPostProcessor|https://github.com/codehaus-plexus/plexus-interpolation/blob/7f8e0920ea9b65e61457d2cd14ed31c7ffe67044/src/main/java/org/codehaus/plexus/interpolation/Interpolator.java#L47]
Currently neither the {{Interpolator}} nor the {{Wrapper}} class is exposed or
can be extended.
As not every {{DefaultFilterInfo}} implementation necessarily relies on the
Plexus Interpolator this should probably be part of a dedicated interface which
is only implemented for {{Interpolator}} based default filters.
was:
The default implementation of {{getDefaultFilterWrappers}} always returns a
single element list containing a {{Wrapper}}
(https://github.com/apache/maven-filtering/blob/9d528d0871d93e317ae21a4b6922cd795502364c/src/main/java/org/apache/maven/shared/filtering/BaseFilter.java#L178).
That Wrapper's Interpolator should be customizable with regards to
#
[ValueSource|https://github.com/codehaus-plexus/plexus-interpolation/blob/7f8e0920ea9b65e61457d2cd14ed31c7ffe67044/src/main/java/org/codehaus/plexus/interpolation/Interpolator.java#L33]
and
#
[InterpolationPostProcessor|https://github.com/codehaus-plexus/plexus-interpolation/blob/7f8e0920ea9b65e61457d2cd14ed31c7ffe67044/src/main/java/org/codehaus/plexus/interpolation/Interpolator.java#L47]
Currently neither the {{Interpolator}} nor the {{Wrapper}} class is exposed or
can be extended.
> Allow customization of Interpolator used for
> BaseFilter.getDefaultFilterWrappers(...)
> -------------------------------------------------------------------------------------
>
> Key: MSHARED-1412
> URL: https://issues.apache.org/jira/browse/MSHARED-1412
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-filtering
> Affects Versions: maven-filtering-3.3.2
> Reporter: Konrad Windszus
> Priority: Major
>
> The default implementation of {{getDefaultFilterWrappers}} always returns a
> single element list containing a {{Wrapper}}
> (https://github.com/apache/maven-filtering/blob/9d528d0871d93e317ae21a4b6922cd795502364c/src/main/java/org/apache/maven/shared/filtering/BaseFilter.java#L178).
> That Wrapper's Interpolator should be customizable with regards to
> #
> [ValueSource|https://github.com/codehaus-plexus/plexus-interpolation/blob/7f8e0920ea9b65e61457d2cd14ed31c7ffe67044/src/main/java/org/codehaus/plexus/interpolation/Interpolator.java#L33]
> and
> #
> [InterpolationPostProcessor|https://github.com/codehaus-plexus/plexus-interpolation/blob/7f8e0920ea9b65e61457d2cd14ed31c7ffe67044/src/main/java/org/codehaus/plexus/interpolation/Interpolator.java#L47]
> Currently neither the {{Interpolator}} nor the {{Wrapper}} class is exposed
> or can be extended.
> As not every {{DefaultFilterInfo}} implementation necessarily relies on the
> Plexus Interpolator this should probably be part of a dedicated interface
> which is only implemented for {{Interpolator}} based default filters.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
