cstamas commented on code in PR #1597: URL: https://github.com/apache/maven/pull/1597#discussion_r1670743379
########## apache-maven/src/assembly/maven/conf/settings.xml: ########## @@ -29,14 +29,14 @@ under the License. | | -s /path/to/user/settings.xml | - | 2. Global Level. This settings.xml file provides configuration for all Maven + | 2. System Level. This settings.xml file provides configuration for all Maven Review Comment: For me the fact that your "Maven installation" setting (that is the _default value_ for global settings) can be overridden by CLI switch `-gs` tells all. Plus, I like naming it more like "system" and not "global". Again, "installation" is just and nothing more than a "sensible default". If you look at it as anything else, you are doing it wrong (or the -gs should not exist). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
