[ https://issues.apache.org/jira/browse/MRELEASE-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17864768#comment-17864768 ]
ASF GitHub Bot commented on MRELEASE-1109: ------------------------------------------ basil commented on code in PR #201: URL: https://github.com/apache/maven-release/pull/201#discussion_r1672776630 ########## maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractRewritePomsPhase.java: ########## @@ -96,7 +96,7 @@ public abstract class AbstractRewritePomsPhase extends AbstractReleasePhase impl * Regular expression pattern matching Maven expressions (i.e. references to Maven properties). * The first group selects the property name the expression refers to. */ - private static final Pattern EXPRESSION_PATTERN = Pattern.compile("\\$\\{(.+)\\}"); + private static final Pattern EXPRESSION_PATTERN = Pattern.compile("\\$\\{(.+?)\\}"); Review Comment: > Causes [MRELEASE-1151](https://issues.apache.org/jira/browse/MRELEASE-1151). As explained in https://github.com/apache/maven-release/pull/202#pullrequestreview-2169941878, https://github.com/apache/maven-release/pull/202 seems to resolves this issue (with one exception), and I think this PR should not have been released without also including https://github.com/apache/maven-release/pull/202. I would recommend that the next release either include https://github.com/apache/maven-release/pull/202 or revert this PR. > update-versions removes the CI-friendly ${revisions} > ---------------------------------------------------- > > Key: MRELEASE-1109 > URL: https://issues.apache.org/jira/browse/MRELEASE-1109 > Project: Maven Release Plugin > Issue Type: Bug > Components: prepare, update-versions > Affects Versions: 2.5.3, 3.0.0-M7 > Reporter: Marcel Stör > Assignee: Konrad Windszus > Priority: Major > Fix For: 3.1.0 > > > Given: a project using CI-friendly versions as per > [https://maven.apache.org/maven-ci-friendly.html] > {code:xml} > <version>${revision}</version> > ... > <properties> > <revision>1.0.0-SNAPSHOT</revision> > </properties> > {code} > If I run {{mvn release:update-versions}} (with or without > {{{}-DautoVersionSubmodules=true{}}}) I expect the release plugin to change > the {{$revision}} property. Instead it blindly replaces > {{<version>${revision}</version>}} with the hard-coded version set on the CLI. -- This message was sent by Atlassian Jira (v8.20.10#820010)